From 75a028272df15c72818f21b1d5abf2f3b50ce832 Mon Sep 17 00:00:00 2001 From: Andrew Hamilton Date: Sun, 28 Nov 2021 22:56:41 +1000 Subject: [PATCH] tools: Dropped python-modulefinder and disassembly. - Modulefinder often has errors. - Both tools aren't commonly used. --- README.md | 4 ++-- eris/eris/tools.toml | 13 +------------ eris/tests/tools_test.py | 3 --- 3 files changed, 3 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 661b295..3fa628d 100644 --- a/README.md +++ b/README.md @@ -31,10 +31,10 @@ Eris maintains an up-to-date set of reports for every file in a codebase. ## Tools -File types(100) | Tools(60) +File types(100) | Tools(58) ----------:| ----- .* | [contents](http://pygments.org/) • [metadata](https://github.com/ahamilton/eris) • [git_diff](https://git-scm.com/docs/git-diff) • [git_blame](https://git-scm.com/docs/git-blame) • [git_log](https://git-scm.com/docs/git-log) -.py | [python_syntax](https://en.wikipedia.org/wiki/Python_syntax_and_semantics) • [python_unittests](https://docs.python.org/3/library/unittest.html) • [pytest](https://docs.pytest.org/en/latest/) • [pydoc](https://docs.python.org/3/library/pydoc.html) • [mypy](http://mypy-lang.org/) • [python_coverage](https://coverage.readthedocs.io/) • [pycodestyle](http://pycodestyle.pycqa.org/en/latest/) • [pydocstyle](http://www.pydocstyle.org/en/2.1.1/usage.html) • [pyflakes](https://pypi.org/project/pyflakes/) • [pylint](https://www.pylint.org/) • [python_gut](https://github.com/ahamilton/eris) • [python_modulefinder](https://docs.python.org/3/library/modulefinder.html) • [dis](https://docs.python.org/3/library/dis.html) • [python_mccabe](https://pypi.org/project/mccabe/) • [bandit](https://pypi.org/project/bandit/) +.py | [python_syntax](https://en.wikipedia.org/wiki/Python_syntax_and_semantics) • [python_unittests](https://docs.python.org/3/library/unittest.html) • [pytest](https://docs.pytest.org/en/latest/) • [pydoc](https://docs.python.org/3/library/pydoc.html) • [mypy](http://mypy-lang.org/) • [python_coverage](https://coverage.readthedocs.io/) • [pycodestyle](http://pycodestyle.pycqa.org/en/latest/) • [pydocstyle](http://www.pydocstyle.org/en/2.1.1/usage.html) • [pyflakes](https://pypi.org/project/pyflakes/) • [pylint](https://www.pylint.org/) • [python_gut](https://github.com/ahamilton/eris) • [python_mccabe](https://pypi.org/project/mccabe/) • [bandit](https://pypi.org/project/bandit/) .pl .pm .t | [perl_syntax](https://en.wikipedia.org/wiki/Perl) • [perldoc](http://perldoc.perl.org/) .p6 .pm6 | [perl6_syntax](https://rakudo.org/) .pod .pod6 | [perldoc](http://perldoc.perl.org/) diff --git a/eris/eris/tools.toml b/eris/eris/tools.toml index 93a1f37..4cf7c04 100644 --- a/eris/eris/tools.toml +++ b/eris/eris/tools.toml @@ -3,8 +3,7 @@ tools_for_extensions = [ [["py"], ["python_syntax", "python_unittests", "pytest", "pydoc", "mypy", "python_coverage", "pycodestyle", "pydocstyle", "pyflakes", - "pylint", "python_gut", "python_modulefinder", "dis", - "python_mccabe", "bandit"]], + "pylint", "python_gut", "python_mccabe", "bandit"]], # [["pyc"], ["pydisasm"]], [["pl", "pm", "t"], ["perl_syntax", "perldoc"]], [["p6", "pm6"], ["perl6_syntax"]], @@ -78,11 +77,6 @@ tools_for_extensions = [ command = "python3.9 -m pylint -f colorized --errors-only" has_color = true -[python_modulefinder] - dependencies = [] - url = "https://docs.python.org/3/library/modulefinder.html" - command = "python3.9 -m modulefinder" - [bandit] dependencies = ["python3-bandit"] url = "https://pypi.org/project/bandit/" @@ -121,11 +115,6 @@ tools_for_extensions = [ error_status = "not_applicable" has_color = true -[dis] - dependencies = [] - url = "https://docs.python.org/3/library/dis.html" - command = "python3.9 -m dis" - [objdump_headers] dependencies = ["binutils"] url = "https://en.wikipedia.org/wiki/Objdump" diff --git a/eris/tests/tools_test.py b/eris/tests/tools_test.py index 7260644..972614a 100755 --- a/eris/tests/tools_test.py +++ b/eris/tests/tools_test.py @@ -103,9 +103,6 @@ class ToolsTestCase(unittest.TestCase): def test_python_gut(self): self._test_tool(tools.python_gut, self.HI_OK) - def test_python_modulefinder(self): - self._test_tool(tools.python_modulefinder, self.HI_OK) - def test_python_mccabe(self): self._test_tool(tools.python_mccabe, self.HI_OK)