ahamilton/eris
1
0
Fork 0
Code Releases Activity

Disabling perl6 because of problems when running it.

Browse source
This commit is contained in:
Andrew Hamilton 2016-10-27 14:03:44 +02:00
parent 3cf7d52a63
commit a93704f19b
3 changed files with 17 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

3
BUGS
View file

@ -1,5 +1,4 @@
Current Current
- When pausing, often getting a ProcessLookupError.
- Within the sandbox sudo is not working for tools. - Within the sandbox sudo is not working for tools.
<- Sudo is working now but its always asking for a password. <- Sudo is working now but its always asking for a password.
- When paging the summary window, with the bottom scroll bar showing, the - When paging the summary window, with the bottom scroll bar showing, the
@ -234,6 +233,8 @@ Fixed
- Some results are always missing their contents and are showing "?". - Some results are always missing their contents and are showing "?".
e.g. golden-files/results/uncrustify-hello_c <- contents and metadata e.g. golden-files/results/uncrustify-hello_c <- contents and metadata
- The tests fail when run in gnome-terminal. - The tests fail when run in gnome-terminal.
- When pausing, often getting a ProcessLookupError.
<- Somehow the worker was dying when running perl6. Revisiting this later.
Won't fix Won't fix

18
tools.py
View file

@ -459,13 +459,15 @@ bandit.dependencies = {"python-bandit", "python3-bandit"}
def _perl_version(path): def _perl_version(path):
stdout, stderr, returncode = _do_command(["perl", "-c", path]) # stdout, stderr, returncode = _do_command(["perl", "-c", path])
return "perl6" if "Perl v6.0.0 required" in stderr else "perl" # return "perl6" if "Perl v6.0.0 required" in stderr else "perl"
return "perl"
def perl_syntax(path): def perl_syntax(path):
return _run_command([_perl_version(path), "-c", path]) return _run_command([_perl_version(path), "-c", path])
perl_syntax.dependencies = {"perl", "rakudo"} # perl_syntax.dependencies = {"perl", "rakudo"}
perl_syntax.dependencies = {"perl"}
def perldoc(path): def perldoc(path):
@ -481,9 +483,9 @@ def perltidy(path):
perltidy.dependencies = {"perltidy"} perltidy.dependencies = {"perltidy"}
def perl6_syntax(path): # def perl6_syntax(path):
return _run_command(["perl6", "-c", path]) # return _run_command(["perl6", "-c", path])
perl6_syntax.dependencies = {"rakudo"} # perl6_syntax.dependencies = {"rakudo"}
def splint(path): def splint(path):
@ -710,8 +712,8 @@ def _tools_for_extension():
"pl": [perl_syntax, perldoc, perltidy], "pl": [perl_syntax, perldoc, perltidy],
"pm": [perl_syntax, perldoc, perltidy], "pm": [perl_syntax, perldoc, perltidy],
"t": [perl_syntax, perldoc, perltidy], "t": [perl_syntax, perldoc, perltidy],
"p6": [perl6_syntax, perldoc], # "p6": [perl6_syntax, perldoc],
"pm6": [perl6_syntax, perldoc], # "pm6": [perl6_syntax, perldoc],
"pod": [perldoc], "pod": [perldoc],
"pod6": [perldoc], "pod6": [perldoc],
"java": [uncrustify], "java": [uncrustify],

9
tools_test.py
View file

@ -128,7 +128,8 @@ class ToolsTestCase(unittest.TestCase):
def test_perl_syntax(self): def test_perl_syntax(self):
self._test_tool(tools.perl_syntax, self._test_tool(tools.perl_syntax,
[("perl.pl", tools.Status.ok), [("perl.pl", tools.Status.ok),
("perl6.pl", tools.Status.problem)]) # ("perl6.pl", tools.Status.problem)
])
def test_perldoc(self): def test_perldoc(self):
self._test_tool(tools.perldoc, self._test_tool(tools.perldoc,
@ -138,9 +139,9 @@ class ToolsTestCase(unittest.TestCase):
def test_perltidy(self): def test_perltidy(self):
self._test_tool(tools.perltidy, [("perl.pl", tools.Status.normal)]) self._test_tool(tools.perltidy, [("perl.pl", tools.Status.normal)])
def test_perl6_syntax(self): # def test_perl6_syntax(self):
self._test_tool(tools.perl6_syntax, # self._test_tool(tools.perl6_syntax,
[("perl6.p6", tools.Status.problem)]) # [("perl6.p6", tools.Status.problem)])
def test_uncrustify(self): def test_uncrustify(self):
self._test_tool(tools.uncrustify, self._test_tool(tools.uncrustify,