From b3dbcddcf64721738f026c5017fa18010a1369f3 Mon Sep 17 00:00:00 2001 From: Andrew Hamilton Date: Mon, 12 Oct 2020 23:13:07 +1000 Subject: [PATCH] tools: Show error message when python-coverage sees old .coverage. --- eris/tools.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/eris/tools.py b/eris/tools.py index ed88be5..c2160aa 100755 --- a/eris/tools.py +++ b/eris/tools.py @@ -324,8 +324,11 @@ def python_coverage(path): ' file was generated.') path = os.path.normpath(path) with tempfile.TemporaryDirectory() as temp_dir: - _do_command([PYTHON_EXECUTABLE, "-m", "coverage", - "annotate", "--directory", temp_dir, path]) + stdout, stderr, returncode = _do_command( + [PYTHON_EXECUTABLE, "-m", "coverage", + "annotate", "--directory", temp_dir, path]) + if returncode != 0: + return Status.problem, stdout cover_filename = path.replace("/", "_") + ",cover" with open(os.path.join(temp_dir, cover_filename), "r") as f: lines = f.read().splitlines(keepends=True)